Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per prompt norm #258

Merged
merged 48 commits into from
Aug 11, 2023
Merged

Add per prompt norm #258

merged 48 commits into from
Aug 11, 2023

Conversation

lauritowal
Copy link
Collaborator

@lauritowal lauritowal commented Jun 15, 2023 •
edited
Loading

No description provided.

@lauritowal lauritowal marked this pull request as draft June 15, 2023 21:45
@lauritowal lauritowal marked this pull request as ready for review June 29, 2023 11:40
derpyplops
derpyplops approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@derpyplops derpyplops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

norabelrose
norabelrose previously requested changes Jun 29, 2023
View reviewed changes
elk/training/burns_norm.py Outdated Show resolved Hide resolved
elk/training/ccs_reporter.py Outdated Show resolved Hide resolved
@derpyplops derpyplops mentioned this pull request Jul 6, 2023
Closed
@lauritowal lauritowal changed the base branch from main to remove-embeddings July 19, 2023 18:08
@lauritowal lauritowal requested review from norabelrose and removed request for norabelrose July 28, 2023 20:06
AlexTMallen
AlexTMallen requested changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@AlexTMallen AlexTMallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly other than the sigmoid layer

elk/training/ccs_reporter.py Outdated Show resolved Hide resolved
elk/training/ccs_reporter.py Outdated Show resolved Hide resolved
elk/training/train.py Outdated Show resolved Hide resolved
AlexTMallen
AlexTMallen approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@AlexTMallen AlexTMallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauritowal lauritowal requested review from norabelrose and removed request for derpyplops and norabelrose August 4, 2023 07:47
norabelrose
norabelrose reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks

elk/training/burns_norm.py Outdated Show resolved Hide resolved
elk/training/burns_norm.py Outdated Show resolved Hide resolved
@lauritowal lauritowal merged commit 7e60fa7 into main Aug 11, 2023
6 checks passed
@lauritowal lauritowal deleted the add_per_prompt_norm branch August 11, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derpyplops derpyplops derpyplops approved these changes

@norabelrose norabelrose norabelrose left review comments

@AlexTMallen AlexTMallen AlexTMallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lauritowal @derpyplops @AlexTMallen @norabelrose