Add git hash in config #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norabelrose
requested changes
Jun 29, 2023
norabelrose
reviewed
Jul 6, 2023
elk/run.py
Outdated
| ) | ||
| except Exception as e: | ||
| print(f"Could not get git revision hash, stack trace: {e}") | ||
| return "ERROR_HASH_NOT_FOUND" |
There was a problem hiding this comment.
Sorry to be so picky about this, but this really shouldn't be any kind of "error" because if the user installs from PyPI then it's expected that there won't be a git hash
There was a problem hiding this comment.
Oh ok. I had assumed that wouldn't be an issue as there aren't any users who are doing that now, or am I mistaken?
There was a problem hiding this comment.
Clément Dumas tried to do it. And I'd like to get more people using it soon
norabelrose
approved these changes
Jul 20, 2023
norabelrose
added a commit
that referenced
this pull request
Jul 20, 2023
This reverts commit 1b31702.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when you want to compare runs across multiple branches/commits