Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save eval runs to separate subfolders by target dataset #174

Merged
merged 4 commits into from
Apr 10, 2023
Merged

save eval runs to separate subfolders by target dataset #174

merged 4 commits into from
Apr 10, 2023

Conversation

ChristyKoh
Copy link
Collaborator

Fixes #173

lauritowal
lauritowal reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@lauritowal lauritowal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull request, I've noticed an error there, too. It should create a memorable directory but default... I have fixed the error in another branch. Should be merged soon

norabelrose
norabelrose approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norabelrose norabelrose merged commit 99fe004 into main Apr 10, 2023
@norabelrose norabelrose deleted the eval_dirs branch April 10, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauritowal lauritowal lauritowal left review comments

@norabelrose norabelrose norabelrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save elk eval runs separately
3 participants
@ChristyKoh @lauritowal @norabelrose