Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make normalization a property of Reporter; support eval with only one split #170

Closed
wants to merge 5 commits into from
Closed

Make normalization a property of Reporter; support eval with only one split #170

wants to merge 5 commits into from

Conversation

AlexTMallen
Copy link
Collaborator

@AlexTMallen AlexTMallen commented Apr 6, 2023 •
edited
Loading

  • removes support for "legacy" normalization
  • Perhaps in the future we may want to just use VINC's implicit normalization rather than doing normalization as a pre-step. However, If we just apply VINC directly to hiddens without normalizing first, we can't do elementwise normalization, nor supervised VINC.

@AlexTMallen AlexTMallen linked an issue Apr 6, 2023 that may be closed by this pull request
Make normalization a property of the Reporter #96
Closed
@AlexTMallen AlexTMallen marked this pull request as ready for review April 11, 2023 19:53
@norabelrose norabelrose mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose Awaiting requested review from norabelrose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make normalization a property of the Reporter
2 participants
@AlexTMallen @norabelrose