Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Multi datasets" #158

Closed
wants to merge 1 commit into from
Closed

Conversation

lauritowal
Copy link
Collaborator

@lauritowal lauritowal commented Mar 29, 2023

Reverts #123

Sorry, I misread Noras previous message, somehow.
Will revert the pull-request for now, and we might want to look better into a possible performance regression first.

Update:
Before reverting, we will test if it actually the changes caused performance regression on GPT2... If not we leave it as it is.

@lauritowal lauritowal requested review from AlexTMallen and norabelrose and removed request for AlexTMallen March 29, 2023 09:31
@AlexTMallen
Copy link
Collaborator

Where have we observed performance regression? Does this mean VINC auroc decreases because of #123?

@lauritowal
Copy link
Collaborator Author

lauritowal commented Mar 29, 2023

@AlexTMallen yeah, when testing the changes of the pull request #123 pull I noticed some VINC auroc decrease in GPT-2 (especially in the last layer).

However, I wanted to be sure and look into it again.... But, I wasn't able to test it again today, I tried elk elicit gpt2 imdb --num_gpus 2 a few times, but the machine ending in .195 keeps freezing for me at some point and the one ending in .37 is down right now. I also wanted to try out some bigger models, like Deberta. I might try this on a different machine, tomorrow. If you can / want you can have a look at it too and see if the performance before merging the pull request is similar to the one after merging it for some models (maybe GPT-2, GPT-2 and Deberta...) and post the results here... If they are quite similar, we can decide to just close this revert pull request.

@lauritowal
Copy link
Collaborator Author

Thanks for testing that Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants