Gather eval stats #157
Closed
Gather eval stats #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
lauritowal
requested changes
Mar 31, 2023
| """ | ||
| REPORTER_DIR = os.path.abspath(reporter_dir) | ||
|
|
||
| if not os.path.exists(REPORTER_DIR): |
There was a problem hiding this comment.
Why do you need to create the reporter_dir first?
| @@ -0,0 +1,56 @@ | |||
| import pandas as pd | |||
| import numpy as np | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
there are missing imports
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| # These are users whose datasets should be included in the results returned by | |||
| # filter_english_datasets (regardless of their metadata) | |||
| INCLUDED_USERS = {"Zaid", "craffel", "lauritowal"} | |||
| INCLUDED_USERS = {"Zaid", "craffel", "lauritowal", "christykoh"} | |||
There was a problem hiding this comment.
You should remove the template changes, since this is not related to visualizing the stats (Same for all the template files / directories)
|
|
|
Not clear what this is doing; happy to look at an updated version in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in a new function
get_metric_across_layersthat can be used to get a metric score of a reporter across layers automatically.Some questions/things to work on
elk gather(open to thoughts on the command)