Replace held_out_split with select_train_val_splits #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norabelrose
requested review from
lauritowal and
AlexTMallen
and removed request for
lauritowal
AlexTMallen
approved these changes
Mar 17, 2023
elk/utils/data_utils.py
Outdated
| Split.TEST: 2, | ||
| } | ||
| splits = sorted(raw_splits, key=lambda k: priorities.get(k, 100)) # type: ignore | ||
| assert len(splits) >= 2, "Must have train and val/test splits" |
There was a problem hiding this comment.
This error message is no longer true: should say "must have at least two of train, val, and test splits".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the logic for determining which splits of a dataset should be used for training & validation into a function in
data_utils.pycalledselect_train_val_splits. This replaces the olderheld_out_splitfunction which was less robust.