Remove marker for cpu test, add marker for future gpu tests #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejaminator
commented
Mar 15, 2023
| - name: Run CPU Tests | ||
| run: pytest -m cpu | ||
| - name: Run normal tests, excluding GPU tests | ||
| run: pytest -m "not gpu" |
There was a problem hiding this comment.
this other PR allows us to stop having to edit both pipelines
#129
thejaminator
commented
Mar 15, 2023
| This is just an example test to show how to use the `gpu` mark | ||
| We'll need to implement a GPU runner in the CI for actual GPU tests | ||
| GPU tests can be run with `pytest -m gpu`""" | ||
| assert True |
There was a problem hiding this comment.
this test won't run because we don't have an actual gpu runner, but i'm just leaving it here to document the pytest.mark.gpu decorator. otherwise the CI doing pytest -m "not gpu" is pretty weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pytest.mark.cpu decorators, so all tests are automatically added to the CI.
For future tests that require the GPU, they can be marked with
pytest.mark.gpuinstead. These tests won't run on the cpu CI