Add Lbfgs #12
Add Lbfgs #12
Conversation
elk/utils_evaluation/parser.py
Outdated
| parser.add_argument("--seed", type=int, default=0) | ||
| parser.add_argument( | ||
| "--model_device", | ||
| type=str, | ||
| default="cuda", | ||
| help="What device to load the model onto: CPU or GPU or MPS.", | ||
| ) | ||
| parser.add_argument( | ||
| "--use_lbfgs", action="store_true", help="Use lbfgs optimizer to train CCS." |
There was a problem hiding this comment.
I propose --optimizer with choices=("adam", "lbfgs")
There was a problem hiding this comment.
I used an enum for type safety. Literal["adam", "lbfgs"] can't be used in argparse.
But maybe you think it's better to use str and then assert that the optimizer is correct?
There was a problem hiding this comment.
You can use choices=("adam", "lbfgs") in argparse. I tend not to use enums because they're verbose— you have to type Optimizer.adam instead of just "adam". For now I'd recommend just using strings + an assert statement. But maybe @lauritowal disagrees.
There was a problem hiding this comment.
Done. Also, the assert is done by argparse in the parser, and I had already an assert in the training code for ccs, so I guess no additional assert is needed.
for more information, see https://pre-commit.ci
Fix #1