Add test for the classifier to be roughly the same as sklearn #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejaminator
changed the title
thejaminator
commented
Mar 9, 2023
| model = LogisticRegression(penalty="none", solver="lbfgs") | ||
| model.fit(features, truths) | ||
| # train a classifier on the data | ||
| classifier = Classifier(input_dim=input_dims, device="cpu") |
There was a problem hiding this comment.
classifier doesn't expose the dtype used. by default the torch linear layer is float32.
so we'll turn the sklearn features from float64 to float32
thejaminator
commented
Mar 9, 2023
| # check that the weights are roughly the same | ||
| sklearn_coef = model.coef_ | ||
| torch_coef = classifier.linear.weight.detach().numpy() | ||
| assert np.allclose(sklearn_coef, torch_coef, atol=1e-2) |
There was a problem hiding this comment.
as a sanity check i also passed random features to torch to make the test fails. it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.