Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #189

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Bugfix #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123f405
refactor: Remove workarounds & edit translations
tatsuz0u Dec 4, 2021
46ffd86
fix: Deleting profiles doesn't work
tatsuz0u Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
types: [closed]
env:
DEVELOPER_DIR: /Applications/Xcode_13.1.app
APP_VERSION: '1.5.2'
APP_VERSION: '1.5.3'
SCHEME_NAME: 'EhPanda'
ALTSTORE_JSON_PATH: './AltStore.json'
BUILDS_PATH: '/tmp/action-builds'
Expand Down
14 changes: 0 additions & 14 deletions EhPanda/App/ViewModifiers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,3 @@ struct PreviewResolver {
))
}
}

extension ScrollView {
func swipeBackable() -> some View {
ZStack {
self
HStack {
Color(.systemGray6)
.opacity(0.01)
.frame(width: 40)
Spacer()
}
}
}
}
2 changes: 1 addition & 1 deletion EhPanda/App/zh-Hans.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@
"Male" = "男性";
"Female" = "女性";
"Mixed" = "混合性别";
"Cosplayer" = "角色扮演者";
"Cosplayer" = "扮装者";
"Other" = "其它";
"Temp" = "临时";

Expand Down
4 changes: 1 addition & 3 deletions EhPanda/View/Detail/DetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ private struct DescScrollView: View {
.withHorizontalSpacing()
}
}
.swipeBackable().frame(height: 60)
.frame(height: 60)
.onReceive(AppNotification.appWidthDidChange.publisher, perform: tryResetItemWidth)
}

Expand Down Expand Up @@ -691,7 +691,6 @@ private struct PreviewView: View {
.withHorizontalSpacing(height: height)
}
}
.swipeBackable()
}
}
}
Expand Down Expand Up @@ -814,7 +813,6 @@ private struct CommentScrollView: View {
}
.drawingGroup()
}
.swipeBackable()
CommentButton(action: toggleCommentAction).padding(.horizontal)
.disabled(!AuthorizationUtil.didLogin)
}
Expand Down
2 changes: 1 addition & 1 deletion EhPanda/View/Setting/EhSettingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ private struct EhProfileSection: View {
"Are you sure to delete this profile?", isPresented: $dialogPresented, titleVisibility: .visible
) {
Button("Delete", role: .destructive) {
performEhProfileAction(.default, nil, selection.value)
performEhProfileAction(.delete, nil, selection.value)
}
}
.onChange(of: selection) {
Expand Down