Prevent automated scanner as well as improving performance #339

EdiWang · 2020-02-25T10:45:53Z

Address #338

…ool and query database every time

Anduin2017 · 2020-02-25T10:48:50Z

While this is a nice fix, your regex expression is super hard to read. Why not copy it to a const var?

EdiWang · 2020-02-25T10:53:17Z

@Anduin2017 good catch, I will work 996 and refact the code

EdiWang · 2020-02-25T11:24:23Z

Consts is a no go, code will end up like this:

[Route("list/{categoryName:regex(" + WebConsts.ROUTE_REGEX_SLUG + ")}")]

And this won't compile:

[Route($"list/{{categoryName:regex({WebConsts.ROUTE_REGEX_SLUG})}}")]

Anduin2017 · 2020-02-25T11:24:55Z

F**k C# compiler.

EdiWang added 4 commits February 25, 2020 18:38

Add regex to post slug to prevent being scanned by automated hacker t…

ff5c84e

…ool and query database every time

Add regex rule on page route

a0f73e6

Apply regex on tag list

8594b0f

Apply regex on category list

9d342db

EdiWang self-assigned this Feb 25, 2020

EdiWang requested a review from Anduin2017 February 25, 2020 10:48

Anduin2017 approved these changes Feb 25, 2020

View reviewed changes

EdiWang merged commit 083f92f into master Feb 25, 2020

EdiWang deleted the anti-boring-scanner branch February 25, 2020 11:24

Provide feedback