Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttyp0 changes (remove Thai and Hebrew), generator fix #3240

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

rohkea
Copy link
Member

@rohkea rohkea commented Jun 18, 2024

This PR does the following changes:

  • ttyp0: removes scripts that are broken in the current renderer (Thai and Hebrew) — resolve ttyp0: Remove Thai and Hebrew glyphs from font #2999,
  • ttyp0: moves the letter F left 1px, to make sure it lines up in menus (requested in the chat),
  • generate_cxx_font.rb: fixes the folder (fonts are now in src/generated, not in src)

I'm not sure about the F change. The previous version looked better in running text (but worse in menus), the new version looks better in menus (but worse in running text). Here's before and after:

Before: F in the menu is to the right of all the other letters, but Fi and Fo combinations look better

After: F in the menu is aligned with other letters, but Fi has too much space between letters

@Ghabry Ghabry added this to the 0.8.1 milestone Jun 18, 2024
@Ghabry
Copy link
Member

Ghabry commented Jun 18, 2024

Thanks for the fixes. Imo the new F looks worse (as running text is more common than menus). Maybe shift the E instead one pixel to the right?

@rohkea
Copy link
Member Author

rohkea commented Jun 18, 2024

Here is version with E shifted to the right:
screenshot-move-both-e-and-f

And here are some examples of the running text.

Original:
fairy-orig

F shifted to the left:
fairy-f-shifted

E shifted to the right:
fairy-e-shifted

@Ghabry
Copy link
Member

Ghabry commented Jun 18, 2024

Okay this triggers now all that want the D and the E | at the same location.

And we cannot move all upper letters by one to the right, this will look bad in other situations.

This doesn't look solvable without redoing the font... So lets just undo this part.

@rohkea rohkea changed the title ttyp0 changes (remove Thai and Hebrew, shift F by 1px), generator fix ttyp0 changes (remove Thai and Hebrew), generator fix Jun 18, 2024
@rohkea
Copy link
Member Author

rohkea commented Jun 18, 2024

I've removed the change of the F letter, reverted the original version.

@carstene1ns carstene1ns marked this pull request as draft June 23, 2024 12:55
@rohkea
Copy link
Member Author

rohkea commented Jun 23, 2024

I've checked, the PR doesn't change Shinonome (the case when Ruby version influences the final file, because of encoding issue), so it can be merged (I hope)

@rohkea rohkea marked this pull request as ready for review June 23, 2024 13:06
Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just one question, why is thai bin and the rest bit, possible typo?

@rohkea
Copy link
Member Author

rohkea commented Jun 24, 2024

Renamed .bin into .bit, thanks for noticing!

@Ghabry Ghabry merged commit 4077070 into EasyRPG:master Jul 2, 2024
12 checks passed
@rohkea rohkea deleted the fix/ttyp0-changes branch July 13, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

ttyp0: Remove Thai and Hebrew glyphs from font
4 participants