Recover proper coverage filtering and add few more tests for legacy s…

…elects
Earlycrusher · Aug 4, 2022 · 03176c7 · 03176c7
1 parent feea6a5
commit 03176c7
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 6 deletions.
diff --git a/kotlinx-coroutines-core/build.gradle b/kotlinx-coroutines-core/build.gradle
@@ -260,12 +260,12 @@ def commonKoverExcludes =
          "kotlinx.coroutines.scheduling.ExperimentalCoroutineDispatcher" // Deprecated
         ]
 
-tasks.koverHtmlReport {
-    excludes = commonKoverExcludes
-}
-
-tasks.koverVerify {
-    excludes = commonKoverExcludes
+kover {
+    filters {
+        classes {
+            excludes.addAll(commonKoverExcludes)
+        }
+    }
 }
 
 task testsJar(type: Jar, dependsOn: jvmTestClasses) {

diff --git a/kotlinx-coroutines-core/common/test/selects/SelectOldTest.kt b/kotlinx-coroutines-core/common/test/selects/SelectOldTest.kt
@@ -90,6 +90,34 @@ class SelectOldTest : TestBase() {
         finish(8)
     }
 
+    @Test
+    fun testSelectUnbiasedComplete() = runTest {
+        expect(1)
+        val job = Job()
+        job.complete()
+        expect(2)
+        val res = selectUnbiasedOld<String> {
+            job.onJoin {
+                expect(3)
+                "OK"
+            }
+        }
+        assertEquals("OK", res)
+        finish(4)
+    }
+
+    @Test
+    fun testSelectUnbiasedThrows() = runTest {
+        try {
+            select<Unit> {
+                expect(1)
+                throw TestException()
+            }
+        } catch (e: TestException) {
+            finish(2)
+        }
+    }
+
     @Test
     fun testSelectLazy() = runTest {
         expect(1)