Optionally keep partial search results even after an exception #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… search raises an exception, sdproxy.searchAPIProxy.call_web_service__PAGINATION will nevertheless return whatever incomplete results it has. This is very useful for production-scale replication where paginated searches are very large and failures not unkown. But by default this is turned off because a naive user would not be aware that the search was incomplete. To turn it on you have to set the constant NEVER_RAISE_EXCEPTION to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to save partial search results. That is, if a paginated search raises an exception, sdproxy.searchAPIProxy.call_web_service__PAGINATION will nevertheless return whatever incomplete results it has, rather than re-raise the exception.
This is very useful for production-scale replication where paginated searches are very large and failures not unknown. But by default this is turned off because a naive user would not be aware that the search was incomplete. To turn it on you have
to set the constant NEVER_RAISE_EXCEPTION to True.