Add some details to the error message when externals are modified #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gold2718
requested changes
Jul 11, 2020
Comment on lines
+404
to
+408
| (2) Alternatively, you do not have to rely on {program_name}. Instead, you can manually | ||
| update out-of-sync externals (labeled with 's' above) as described in the | ||
| configuration file {config_file}. (For example, run 'git fetch' and 'git checkout' | ||
| commands to checkout the appropriate tags for each external, as given in | ||
| {config_file}.) |
There was a problem hiding this comment.
What about using the --exclude option to ignore that external? I think that should be a third alternative.
There was a problem hiding this comment.
@gold2718 good point. I just pushed an update; let me know what you think.
gold2718
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some details to the error message when externals are modified
A user commented that this error message was unclear, particularly if you don't know how to revert changes in git. This is hopefully a small improvement, at least.
User interface changes?: No
Fixes: None
Testing:
make utest,make stest,make linttest removed: none
unit tests: pass
system tests: pass
manual testing: examined error message as printed