Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Bazaar Search not working correctly for Iksar, Vashir, Drakkin and Froglok races #4379

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

neckkola
Copy link
Contributor

@neckkola neckkola commented Jun 1, 2024

The Bazaar Search feature by race was not working correctly for iskar, froglok, vahshir and drakkin due to the conversion between player race and server race. This conversion was not accounted for and has been corrected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

The following image is a search by race = vahshir for a hammer of scourge which is useable by Vahshir. Previously, this search would return no items.

image

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius changed the title [Fix} Bazaar Search not working correctly for Iksar, Vashir, Drakkin and Froglok races [Fix] Bazaar Search not working correctly for Iksar, Vashir, Drakkin and Froglok races Jun 2, 2024
@Akkadius Akkadius merged commit 59e4adb into EQEmu:master Jun 2, 2024
1 check passed
@Akkadius Akkadius mentioned this pull request Jun 2, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants