Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Cleanup Body Type Code #4366

Merged
merged 7 commits into from
Jun 2, 2024
Merged

[Cleanup] Cleanup Body Type Code #4366

merged 7 commits into from
Jun 2, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented May 30, 2024

Description

  • Introduces a BodyType namespace for stuff like IsValid.
  • Cleans up a lot of the logic in finding a body type, checking for a valid body type, etc.
  • Adds #find body_type subcommand.

Type of Change

  • New feature

Testing

  • Logged in game, ran around, didn't notice any issues, can post screenshots or videos as necessary if there is specific functionality we need tested.
    image
    image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab changed the title [Cleanup] Cleanup Body Type-based Code [Cleanup] Cleanup Body Type Code Jun 1, 2024
@Kinglykrab Kinglykrab merged commit 8640776 into master Jun 2, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the cleanup/body_type_code branch June 2, 2024 08:25
@Akkadius Akkadius mentioned this pull request Jun 14, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
* [Cleanup] Cleanup Body Type-based Code

* Update bodytypes.cpp

* Final

* Update body_type.cpp

* Cleanup

* Cleanup

* Formatting

---------

Co-authored-by: Akkadius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants