[Combat] Adjustments to Crippling Blows/Slay Undead and Confirmed Critical Code #4354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After moving to master, we had reports of Crippling Blows, Slays and criticals not always working as intended. Number of reports of slays in the double digit damage. We have utilized this reordered and I think a bit more readable logic for years. I also have increased combat logic and tuning to allow custom servers such as solo only servers to help ramp up that damage or ramp it down to better account for their content.
Rule Added:
RULE_REAL(Combat, SlayDamageAdjustment, 0.5, "Slay Damage Adjustment Default: 0.5")
Type of change
Please delete options that are not relevant.
Testing
Post Adjustment showing holy blade cleansing with an appropriate value for DoN level characters.
Checklist