[Combat] Adjustments to Crippling Blows/Slay Undead and Confirmed Critical Code

[fryguy503]

Description

After moving to master, we had reports of Crippling Blows, Slays and criticals not always working as intended. Number of reports of slays in the double digit damage. We have utilized this reordered and I think a bit more readable logic for years. I also have increased combat logic and tuning to allow custom servers such as solo only servers to help ramp up that damage or ramp it down to better account for their content.

Rule Added:

RULE_REAL(Combat, SlayDamageAdjustment, 0.5, "Slay Damage Adjustment Default: 0.5")

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Testing

Post Adjustment showing holy blade cleansing with an appropriate value for DoN level characters.

Checklist

• I have tested my changes
• I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
• I own the changes of my code and take responsibility for the potential issues that occur