New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule] Mob Offensive and Weapon Skill static tables #4328

Merged

Kinglykrab merged 3 commits into master from trust/CombatStaticOffenseWeaponSkillNPC

May 25, 2024

Contributor

fryguy503 commented May 25, 2024

Description

This allows server operators to use a fixed weapon and offensive skill table for NPC's, Default rule is not enabled. This helps adjust the damage on mobs where skills are using the older skill system and mobs have a very inconsistent hit range and trivializes many mobs and encounters.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Testing

Before adjustment:

After adjustment:

Clients tested:

Checklist

I have tested my changes
I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
I own the changes of my code and take responsibility for the potential issues that occur


[Rule] Mob Offensive and Weapon Skill static tables

b16c252

fryguy503 requested a review from Kinglykrab

May 25, 2024 19:14

Kinglykrab reviewed

View reviewed changes

zone/attack.cpp Outdated Show resolved Hide resolved

Kinglykrab reviewed

View reviewed changes

zone/attack.cpp Outdated Show resolved Hide resolved

Kinglykrab reviewed

View reviewed changes

zone/attack.cpp Outdated Show resolved Hide resolved


Adjustments per comments

7afacc3

Kinglykrab reviewed

View reviewed changes

zone/attack.cpp Outdated Show resolved Hide resolved

Kinglykrab reviewed

View reviewed changes

zone/attack.cpp Outdated Show resolved Hide resolved


Adjustments - Thanks KK

2e120ac

Kinglykrab approved these changes

View reviewed changes

Kinglykrab merged commit 3e34447 into master

2 checks passed

Kinglykrab deleted the trust/CombatStaticOffenseWeaponSkillNPC branch

May 25, 2024 21:38

fryguy503 added a commit that referenced this pull request


Missed a mob offense section for PR #4328

e867e6c

fryguy503 mentioned this pull request

[Bug Fix] Missed a mob offense section for PR #4328 #4331

Merged

4 tasks

Kinglykrab pushed a commit that referenced this pull request


[Hotfix] Missed a mob offense section for PR #4328 (#4331)

f70078d

Akkadius mentioned this pull request

[Release] 22.51.0 #4347

Merged

catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request


[Rule] Mob Offensive and Weapon Skill static tables (EQEmu#4328)

9149f69

* [Rule] Mob Offensive and Weapon Skill static tables

* Adjustments per comments

* Adjustments - Thanks KK

catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request


[Hotfix] Missed a mob offense section for PR EQEmu#4328 (EQEmu#4331)

8dfedc9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment