Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Add validation to RemoveXTarget #4324

Merged
merged 1 commit into from
May 25, 2024

Conversation

Akkadius
Copy link
Member

Description

Adds validation to RemoveXTarget. Ensures the xtarget manager is valid, ensures the mob to be removed is valid and additionally checks to see if xtargets is even enabled before running the business logic.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Xtarget functionality still works as expecfted.

2024-05-24.19-43-39.mp4

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab merged commit 98b1371 into master May 25, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the akkadius/x-target-crash-fix branch May 25, 2024 01:54
@Akkadius Akkadius mentioned this pull request May 26, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants