Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Corpses] Corpse searches for items did not search augs #4289

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

noudess
Copy link
Contributor

@noudess noudess commented Apr 26, 2024

Description

I have a section in my global player quest that looks for an item on a player and acts accordingly. If a player dies, this code was not finding an aug on the corpses causing it to behave incorrectly.

Using this version of hasitem.pl : https://github.com/ProjectEQ/projecteqquests/blob/master/plugins/check_hasitem.pl#L35

I updated $client->HasItemOnCorpse($item_id) to check for augs on the items on corpses.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

This fixes the issue. Video of entering zone before fix (and item given incorrectly) and after

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab merged commit 37e21d7 into EQEmu:master Apr 27, 2024
1 check passed
@Akkadius Akkadius mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants