Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] GLAA fix after database.cpp updates #4277

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Conversation

neckkola
Copy link
Contributor

Description

Group LeadershipAA was not being sent to clients correctly after the database.cpp updates and changes to use the repo pattern. Issue was traced to saving the leadership aa data to the group_leaders table. The repo was converting to a std::string and was truncating at the first 0x00, creating the issue.

Solution:
Create an encode/decode function within Database to add char('0') to the values, mirroring the builtin behavior of the RoF2 client in various places. Therefore, the the repo treats it correctly. Also, rewrote the save routine to also use the repo and this functionality. There are no db changes required, the existing blob datatype remains unchanged.

Type of change

Bug fix.

  • Bug fix (non-breaking change which fixes an issue)

Testing

https://1drv.ms/v/s!AupA3qRrvt-1oc42Wt8qUfnKWbuOkw

Clients tested:
The solution was tested with RoF2 and UF client.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Akkadius and others added 5 commits April 15, 2024 06:55
This seems to resolve the GroupAA issue.  Tested with two characters joining a group.  Functions the same as previous builds like 22.45, 22.46, etc.
@Akkadius Akkadius merged commit 64fefae into master Apr 21, 2024
2 checks passed
@Akkadius Akkadius deleted the akkadius/glaa-fix branch April 21, 2024 01:13
@Akkadius Akkadius mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants