[Spells] Normal Group Spells (non-raid) landed twice on caster #4240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When casting group buffs (in a non-raid situation) the spell was being cast twice on the original caster.
Type of change
Testing
Before this fix, casting a spell like Pack Chloroplast or Group Resist magic landed on caster twice:
https://cdn.discordapp.com/attachments/736008216906825858/1224719140967944344/image.png?ex=661e8395&is=660c0e95&hm=191e4a949c1bec0404688f911619dda8a16ae7b690898092d39b7bf0dde4e6c4&
I tested after the fix. I also went in and made sure this did not impact raids or non-grouped cases. I also found and deleted a comment in Groups::CastGroupSpell() that was incorrect, and removed a line commented out long ago.
Clients tested: RoF2
Checklist