-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German data formats (dates, decimal separator etc.) are not supported #1493
Comments
Hi @KarasKsenia |
Hello, I resolved all merge conflicts, but AppVeyor build fails, and there is no specific info in the build log, why did it fail. Can you please look into it and overall check the problem I described above? |
Hi @swmal here is the unit test, which reproduces the error. In the places where the unit test asserts fail, you can see that the wrong cell format is identified. As a result, the values in the cells do not match the original numbers in the attached Excel file, e.g., with time and date formats. The Excel test file is attached below.
|
Just an update. I am working with this issue and have found several bugs and issues with localizations. I will try to fix the bugs and I will add a new property so you can add your own format codes for the build-in number formats per culture. I will also add a call-back function from the ExcelRangeBase.Text property, so you can manipulate any number format. |
See update in EPPlus 7.2.1 |
@JanKallman thank you very much for fixing !! |
EPPlus usage
Commercial use (I have a commercial license)
Environment
Windows
Epplus version
7.1.3
Spreadsheet application
Excel
Description
Hi everyone,
it seems like this issue has a lot in common with the #1483, but has more different formats, that are not supported yet (such as "dd.mm.yyyy" for German documents instead of "mm-dd-yy" for English ones). I used this test to ensure that the most common German specific data formats are supported:
I also created the PR #1491 with the possible fix for this issue. The main changes are new methods to get the culture specific data formats in ExcelNumberFormatXml.cs:
![image](https://private-user-images.githubusercontent.com/170731948/340322189-b0207b39-8107-40ac-aa0f-2539aa72cb47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NDQ1OTQsIm5iZiI6MTcyMTQ0NDI5NCwicGF0aCI6Ii8xNzA3MzE5NDgvMzQwMzIyMTg5LWIwMjA3YjM5LTgxMDctNDBhYy1hYTBmLTI1MzlhYTcyY2I0Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMFQwMjU4MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNzI5ZWM4NjkyZjRhMTk4MWYxNWE4MjU5ZjZmNDdjMWVhNmY3ZjlkM2U5YTZlZWRmYThiOWQzZmE4ZDI1NTc5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.3MmJuuIIKCJEGAygKM5KAJTP5OLlA6ar819uCeMJqWA)
The text was updated successfully, but these errors were encountered: