PIP-1562-add-samtools-sort-params #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leepc12
approved these changes
Jun 8, 2021
Comment on lines
+375
to
+376
| ${if defined(sort_threads) then ("--sort-threads " + sort_threads) else ""} \ | ||
| ${if defined(sort_memory) then ("--sort-memory " + sort_memory) else ""} \ |
There was a problem hiding this comment.
There is a simpler expression for this. It's ignored if any variable in the expression is not defined.
${"--sort-threads " + sort_threads} \
${"--sort-memory " + sort_memory} \
There was a problem hiding this comment.
Nice, didn't know about that. To me it does look a little weird though, since I don't think concatenating String with String? is a valid WDL expression. Is it part of the spec? To me it seems like what you wrote should be an error.
I think I'll leave this as is since it is clearer IMO.
|
I'm not actually sure it reduces the temp bam count, this PR just exposes it as a pipeline option so it can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.