DSERV-546-variants #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrohr
requested changes
Jul 11, 2024
| ] | ||
|
|
||
| CATALOG_API_FREQ = 'https://api-dev.catalog.igvf.org/api/variants/freq?page=0&maximum_af=1&limit=500' | ||
| CATALOG_API_VARIANTS = 'https://api-dev.catalog.igvf.org/api/variants?page=0&limit=500' |
There was a problem hiding this comment.
should we use production instead? we cant guarantee stability of the api-dev, or make it configurable
There was a problem hiding this comment.
production API may not satisfy our need. For example right now api/variants/freq endpoint in production can't change limit value. This regulome UI is just a demo for now. I don't think it will be released very soon. I can change the API to production API once it is updated.
| notifications[region_query] = 'Failed: invalid region input' | ||
| continue | ||
| logging.info(f'api: {api}') | ||
| res = requests.get(api).json() |
There was a problem hiding this comment.
this line may raise many exceptions... should we include an error message for backend failure such as "try again soon" for example?
There was a problem hiding this comment.
sounds good. Will add it!
pedrohr
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.