Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update associations on object delete #485

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Update associations on object delete #485

merged 5 commits into from
Jan 28, 2021

Conversation

andrykonchin
Copy link
Member

Fixed associations when a model is deleted.

Changes:

  • fixed broken cached ids on the associated model's side for belongs_to and has_and_belongs_to_many
  • fixed referential integrity (nullify) for has_many and has_one
  • fixed raising exception when association with broken foreign key is loading

Based on #484.

Close #467.

@andrykonchin andrykonchin force-pushed the update-associations-on-object-delete branch from cf7403e to d59a67b Compare January 24, 2021 14:05
@andrykonchin andrykonchin merged commit cb417b4 into master Jan 28, 2021
@andrykonchin andrykonchin deleted the update-associations-on-object-delete branch January 28, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parent association record of object that :belongs_to another object not deleted on object delete/destroy
2 participants
@andrykonchin @kkan