-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PID information to -LL_miss_file output #6896
Add PID information to -LL_miss_file output #6896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing. It looks like a few tweaks are needed: see the detailed responses.
(Please reply to each review comment and mark resolved if resolved and then click re-request review when ready.) |
(Click the circular arrow when ready for re-review; xref docs https://dynamorio.org/page_code_reviews.html#autotoc_md118) |
Merged. Thank you for contributing! |
It seems this patch causes compilation errors on more recent (17) versions of clang:
|
When using simulator parameters -LL_miss_file option, I noticed that the output was insufficient for detailed analysis, especially when distinguishing cache misses across processes. This limitation becomes more apparent in environments where multiple processes may experience cache misses at similar virtual memory addresses, potentially leading to ambiguous outputs.
So, I have updated the dump_miss function within caching_device_stats.cpp to include the PID in the output. This small yet impactful change ensures that each cache miss log entry is prefixed with the PID of the process, thereby enabling users to better correlate the cache misses with specific processes.