LoggerFactory support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylernap
approved these changes
May 27, 2022
this includes a Java 8 runtime requirement, but we already effectively require this, so that's fine
…antage of better logger names
89bab7d
to
77aaafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log4cats added a new capability trait called
LoggerFactory, which represents the ability to create a named logger. This makes it easier for applications to have helpfully named loggers throughout the app, instead of having a single global logger used everywhere.This PR changes the library's entry points from requiring
Logger[F]to requireLoggerFactory[F]. It sets a default logger name ofcom.dwolla.security.crypto.CryptoAlg, although this can be overridden by users.