Don't compute sin, cos twice for the same angle #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are few cases in code where exprensive functions are called twice for the same angle. Newer runtimes are able to optimize such cases and speed of my version and current one will be the same. But older runtimes cannot do that.
Benchmarks:
In
drawTicks(Benchmark):current - 1 655 ns
new - 677 ns
current - 426 ns
new - 198 ns
In
differenceBetweenAngles(Benchmark):current - 2 982 ns
new - 1 830 ns
current - 436 ns
new - 425 ns
As you can see, newer runtime optimized
differenceBetweenAnglesand speed is almost the same