Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW : Api resource file and new resource class #30727

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

atm-irvine
Copy link
Contributor

NEW|New Resource

I created the api file for resources and generate a new class file as well to be up-to-date with Dolibarr practice and convention

@@ -81,7 +81,7 @@
$extrafields = new ExtraFields($db);
$hookmanager->initHooks(array('agendaresource'));

$object = new Dolresource($db);
$object = new Resource($db);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word Resource is reserved in PHP, this is why we are using DolResource.
For information, in the past we were using "Resource" and we had to revert to DolResource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been taking care of your suggestions

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants