qual: PHPStan for tva.class.php #30711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdocs/compta/tva/class/tva.class.php 57 Property Tva::$total has no type specified. htdocs/compta/tva/class/tva.class.php 59 Property Tva::$datep has no type specified. htdocs/compta/tva/class/tva.class.php 60 Property Tva::$datev has no type specified. htdocs/compta/tva/class/tva.class.php 61 Property Tva::$amount has no type specified. htdocs/compta/tva/class/tva.class.php 62 Property Tva::$type_payment has no type specified. htdocs/compta/tva/class/tva.class.php 924 Method Tva::getKanbanView() has parameter $arraydata with no value type specified in iterable type array.
mdeweerd
reviewed
Aug 21, 2024
| @@ -163,7 +163,7 @@ public function create($user) | |||
| $now = dol_now(); | |||
|
|
|||
| // Clean parameters | |||
| $this->amount = trim($this->amount); | |||
| $this->amount = (float) $this->amount; | |||
There was a problem hiding this comment.
I've been "PHPDoc typing" in several cases that monetary values can be either string or float because price2num will ensure that they have the desired count of digits after the decimal dot.
There was a problem hiding this comment.
Yes, that's what I figured out with the phan warnings.
So I've updated to:
/**
* @var float|string VAT amount
*/
public $amount;
and
// Clean parameters
$this->amount = (float) price2num($this->amount);
There was a problem hiding this comment.
Actually, you can keep
$this->amount = price2num($this->amount);
And whenever $this->amount is used in a computation, cast it with (float).
It would be better to have a class represent monetary and quantity values IMHO, but that's a task in itself. That class would be able to handle all the operators +, -, /, ... .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htdocs/compta/tva/class/tva.class.php 57 Property Tva::$total has no type specified.
htdocs/compta/tva/class/tva.class.php 59 Property Tva::$datep has no type specified.
htdocs/compta/tva/class/tva.class.php 60 Property Tva::$datev has no type specified.
htdocs/compta/tva/class/tva.class.php 61 Property Tva::$amount has no type specified.
htdocs/compta/tva/class/tva.class.php 62 Property Tva::$type_payment has no type specified.
htdocs/compta/tva/class/tva.class.php 924 Method Tva::getKanbanView() has parameter $arraydata with no value type specified in iterable type array.