Qual: Fix phan notifications for compta/facture/card #30667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b710b80
to
fcfd39b
Compare
|
@eldy The main question about these lines where $remise_percent and $dateinvoice are undefined is: should the be fetched with GETPOST or not? dolibarr/htdocs/compta/facture/card.php Lines 3240 to 3246 in fcfd39b |
6207450
to
831c812
Compare
adc4456
to
e3bde40
Compare
078690b
to
e3269e9
Compare
|
@eldy I've ignored the PhanUndeclaredProperty notice again so that this PR can be integrated - I think that the remaining ones were introduced since I started this PR. |
eldy
requested changes
Sep 29, 2024
htdocs/compta/facture/card.php
Outdated
| @@ -3297,7 +3302,7 @@ | |||
| $classname = ucfirst($subelem); | |||
|
|
|||
| $expesrc = new $classname($db); | |||
| '@phan-var-force CommonObject $expesrc'; | |||
| '@phan-var-force Facture|Commande $expesrc'; | |||
There was a problem hiding this comment.
I think the type of object in this case is Expedition
e3269e9
to
539e724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Fix phan notifications for compta/facture/card
Disable ignores for compta/facture/card.php and fix notices.