Add endpoint /contract/expired to get expired contracts #30559
Conversation
Signed-off-by: kadogo <[email protected]>
|
Hello @eldy Does it mean I need to fix the spaces / tabs issues mentionned here https://github.com/Dolibarr/dolibarr/actions/runs/10267943407/job/28409725198?pr=30559 and that the PR itself will be good to be merged ? |
|
PR are analysed only once there is no CTI errors. |
|
Hello @eldy The PR is to have a way to get the expiration like we can see in the interface.
It really looks like it is the contract that is expired based on the number of days that we configure in the backend configuration. Our Dolibarr version is pretty old, so maybe there are some differences with the stable version. Regards |
No it is not the contract, it is the line of contract (called "service lines"). On screenshot we see the date of end of line. But each line is inside one and only contract, so we can show the contract once we have an expired line. Note that we can have several times the same contract if a contract has 2 lines expired. |
|
Hello @eldy In the interface it really looks like it is the contract, but I don't mind changing it as contract/lines/expired if you prefer. But the return is a contract object and not just the expired lines. Is that alright? Is there a notion of begin / end of a contract that is stored when the contract is expired? |
No. There is no notion of begin / end of a contract stored, expiration is stored into each lines. |
NEW|New Adding /contracts/expired endpoint
The interface let us see the contracts that will be expiring based on a configuration value. We wanted a way to get them through the web service. It was easier to just add an endpoint for it than doing multiple search.
Our instance is pretty old (14.0.5) but the patch applied properly on the develop branch.
Don't hesitate to update the code if there is a better way to do.
Cheers