FIX: notification: error 500 in fixed emails due to a bad copy/paste #29580
Conversation
| } | ||
| if (!empty($mailTemplateLabel) && is_object($emailTemplate) && $emailTemplate->id > 0) { | ||
| // Set output language | ||
| $outputlangs = $langs; | ||
| if ($obj->default_lang && $obj->default_lang != $langs->defaultlang) { |
There was a problem hiding this comment.
Why removing the use of the recipient user language ?
Can you check the alternative fix I pushed is ok for you ? (fdb63a6)
There was a problem hiding this comment.
@eldy Your fix doesn't seem right to me as $obj too doesn't exist in this context (this code has been copy/pasted from ~200 lines above by the contributer of PR #29407 but not thouroughly adapted to the context).
Those mails are target to a fixed list of email addresses set in module settings, and not to Dolibarr users, so there is no way the get a custom language from. The translation of the mail body in the block of code above my fix use $langs and not $outputlangs anyway, and as far as I understand, this is the right thing to do.
There was a problem hiding this comment.
Right $obj must be replaced with $object
Done this way in fix in develop branch.
eldy
added
the
Discussion
…_FIX_fixed_notif_langs
The fixed e-mails are not translated but #29407 copy/pasted code from per-user notifications, that do use variable
$outputlangs