Link type extrafields on supplier order line are no longer working

[IC-Ilies]

Bug

Hello,

When i attempted to create an extrafield (link to an other object) on a supplier order line, this error showed up :
selectForForms: Error bad setup of field objectdescorig=Contact, objectfield=commande_fournisseurdet:options_buyprice

I already found the origin of this bug and i will make a pull request, but i suspect that this problem will possibily occur on many other elements, since the problem comes from the 'getElementProperties' function (core/lib/functions.lib.php) and that many elements may not have been integrated into this function (maybe)

Dolibarr Version

19.0.1

Environment PHP

8.1.27

Environment Database

10.5.23-MariaDB

Steps to reproduce the behavior and expected behavior

Set up an extrafield of type link on supplier order lines (from code or dolibarr's interface)
Link it to whatever you want (even the basic examples provided into the help tooltip)
Create it
When you go to the line form on any order supplier, you'll see the error

Attached files

No response

[JonBendtsen]

@IC-Ilies what if you searched for the old text string(s) in other modules? would you then find them?

[IC-Ilies]

@IC-Ilies what if you searched for the old text string(s) in other modules? would you then find them?

I don't think it is as simple as that, because i would have to search for every class that has en element attribute that is not in correlation with it's name (and there is a lot of dolibarr classes :p ) . For now i think i will just check the issues and let this one open if another similar bug shows

[eldy]

Can you provide the definition (screenshot of extrafield setup) of your extrafield coefficient ?

[IC-Ilies]

@eldy Here it is :)

[eldy]

So yes, trouble is surely into
getElementProperties that does not handle all the cases, you can send a pr to add support for commande_fournisseurdet
Previoudly all cases non standard were handled at different places. We introduced getElementProperties to have this handled in 1 place only but may have forgotten cases...