feat: condition domain certificate field

[lorenzomigliorero]

Steps taken

Merge add-domain and update-domain in one component

There were a lot of duplications before, and the only difference between the files was the create vs update mutation. One file is easier to manage, and we're sure they share now the same validation rules (before they weren't).

Add a condition to show certificate field when HTTPS is true

Close modal on either success or fail

I see a PR for it, but I'm starting adding the fix here

Summary by CodeRabbit

• New Features

  • Enhanced domain management functionality, allowing users to create or update domains within the same component.
  • Improved validation for domain fields, ensuring proper input formats and mandatory values.

• UI Improvements

  • Updated icons for domain actions, enhancing visual clarity.
  • Refined user interface for the "Add Domain" button, increasing interactivity.

• Bug Fixes

  • Adjusted conditional rendering for certificate selection based on user input, improving usability.

• Chores

  • Updated database schema to enforce required values for critical domain attributes, enhancing data integrity.

[lorenzomigliorero]

@Siumauricio, what is this extension doing exactly? It never shows relevant information, and I found it quite confusing. Should we maybe add an issue template instead? What do you think?

[Siumauricio]

@lorenzomigliorero in theory it should give some suggestions about the code and better practices, but is more the unnecesary comments

[lorenzomigliorero]

Yeah, I found it very confusing. Eventually, we can make the biome rules more strict and add a PR template.
I don't think this extension is necessary.

[lorenzomigliorero]

Hey @Siumauricio, I worked a bit on this form, and I made several improvements.

• Now the same validation rules are shared for both API and form
• The certificate is required only on HTTPS
• I removed unnecessary required modifier from the APIs, because fields were already required
• APIs inputs were all required, but this is not necessary. They should respect the validation rules
• The form reset only when a new domain is added

This is a big improvement because it avoids many duplications, and it should be the standard for all APIs/forms.
We can schedule a refactor later.

[Siumauricio]

All looks good @lorenzomigliorero thank you so much for this refactor

I just remove the flushsync due to this suggestion of react docs Ref

The form reset wasn't working because we wasn't reset the form properly since the recommend way to reset a form is inside a useEffect Ref and also added the refetch only when we have a domainId specified