Skip to content

Commit

Permalink
psr2 fixes to prior commit
Browse files Browse the repository at this point in the history
  • Loading branch information
bradymiller committed Sep 8, 2019
1 parent b60929f commit 3eab4c6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
11 changes: 6 additions & 5 deletions src/Core/ModulesApplication.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ public function __construct(Kernel $kernel, $webRootPath, $modulePath, $zendModu
$this->bootstrapCustomModules($kernel->getEventDispatcher(), $customModulePath);
}

private function bootstrapCustomModules($eventDispatcher, $customModulePath) {
private function bootstrapCustomModules($eventDispatcher, $customModulePath)
{
// we skip the audit log as it has no bearing on user activity and is core system related...
$resultSet = sqlStatementNoLog($statement = "SELECT mod_name, mod_directory FROM modules WHERE mod_active = 1 AND type != 1 ORDER BY `mod_ui_order`, `date`");
$db_modules = [];
Expand All @@ -82,10 +83,11 @@ private function bootstrapCustomModules($eventDispatcher, $customModulePath) {
// TODO: stephen we should fire an event saying we've now loaded all the modules here.
}

private function loadCustomModule($module, $eventDispatcher) {
private function loadCustomModule($module, $eventDispatcher)
{
if (!is_readable($module['path'] . DIRECTORY_SEPARATOR . self::CUSTOM_MODULE_BOOSTRAP_NAME)) {
// TODO: stephen need to escape filename here.
error_log("Custom module file path " . errorLogEscape($module['path'] )
error_log("Custom module file path " . errorLogEscape($module['path'])
. DIRECTORY_SEPARATOR . self::CUSTOM_MODULE_BOOSTRAP_NAME
. " is not readable. Check directory permissions");
}
Expand All @@ -94,8 +96,7 @@ private function loadCustomModule($module, $eventDispatcher) {
// do we really want to just include a file?? Should we go all zend and actually force a class instantiation
// here and then inject the EventDispatcher or even possibly the Symfony Kernel here?
include $module['path'] . DIRECTORY_SEPARATOR . self::CUSTOM_MODULE_BOOSTRAP_NAME;
}
catch (Exception $exception) {
} catch (Exception $exception) {
error_log(errorLogEscape($exception->getMessage()));
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/Events/PatientReport/PatientReportEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

use Symfony\Component\EventDispatcher\Event;

class PatientReportEvent extends Event {
class PatientReportEvent extends Event
{

/**
* This event fires after the action buttons for the report have rendered.
Expand Down

0 comments on commit 3eab4c6

Please sign in to comment.