Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2434 - Dynamic Metrics - Genmapper - Show Data Layers #2515

Merged

Conversation

kodinkat
Copy link
Contributor


  • Collapsible data layer settings area.
  • Add/Remove field data layers to be captured.
  • Data layer settings persisted & saved within local browser storage.

Screenshot 2024-06-12 at 16 41 18

Screenshot 2024-06-12 at 16 41 30

  • Ability to specify field to be used for node color; or, revert to using default chart colors.

Screenshot 2024-06-12 at 16 44 15

Screenshot 2024-06-12 at 16 45 43

  • Captured data layers appended to node content and displayed as tooltip.

Screenshot 2024-06-12 at 16 42 36

  • Captured data layers complete listing, also displayed within details section following node click.

Screenshot 2024-06-12 at 16 42 53

@corsacca
Copy link
Member

@kodinkat,
If you clear the cookie and refresh, and select the color, the tree is not updated:
image

@corsacca
Copy link
Member

@kodinkat Nice work.

  1. Can we try to extend the height of the nodes with extra data?

2, UI:
Screenshot 2024-06-28 at 9 35 45 AM

@kodinkat
Copy link
Contributor Author

kodinkat commented Jul 1, 2024

Screenshot 2024-07-01 at 16 26 55

Screenshot 2024-07-01 at 16 27 35

Screenshot 2024-07-01 at 16 28 12

Screenshot 2024-07-01 at 16 28 39

@kodinkat
Copy link
Contributor Author

kodinkat commented Jul 5, 2024

Screenshot 2024-07-05 at 12 26 19

@kodinkat
Copy link
Contributor Author

Screenshot 2024-07-11 at 13 41 32

Screenshot 2024-07-11 at 13 42 10

Screenshot 2024-07-11 at 13 42 31

@corsacca
Copy link
Member

Nice work @kodinkat! I like how this is shapping up
Can the data in the nodes be in the same order as the layers?
image

'data_layer_settings_color_default_label' => __( 'Default', 'disciple_tools' ),
'add_data_layer' => __( 'Add Data Layer', 'disciple_tools' ),
'icon_data_layer' => __( 'Show as icons', 'disciple_tools' ),
'del_data_layer' => __( 'x', 'disciple_tools' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodinkat, x does not need to be translated.

@corsacca
Copy link
Member

Thank you @kodinkat!!

@corsacca corsacca merged commit 2fd66a5 into DiscipleTools:develop Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Metrics > Genmapper: Show Data Layers
2 participants