Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit page components integration fixing #2510

Conversation

Ashima-Arora
Copy link

@micahmills

Here we have added dt-tags-related fixes in global-functions.php
and removed extra function in jQuery code which checked duplicate in contact_email and contact_phone fields. Kindly look in the changes and provide us with your feedback. Thanks!

@gp-birender @Vijenderrr

@Ashima-Arora Ashima-Arora changed the base branch from develop to next May 31, 2024 11:06
@Ashima-Arora
Copy link
Author

@micahmills

We have noticed that there are few errors when checks runs even after we have rebased our branch. Kindly assist us. Thanks!

@micahmills micahmills self-assigned this Jun 3, 2024
Copy link
Collaborator

@micahmills micahmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great for location fields when the mapbox key is activated.

It doesn't appear to be working if there is no mapbox key and it fallback to the regular location field.
Screenshot 2024-06-03 at 10 48 58 AM

Please check that we aren't breaking the standard location field with these changes.

@Ashima-Arora
Copy link
Author

@micahmills

After the discussions in our last call, we have put the dt-location work on hold.
We added ( $field_type === 'location_meta' ) to get the location field displayed. However, that wasn't worked on. We will resume work after you provide us with instructions on the location field updates. Thus, I will revert these changes for now. Thank you!

@micahmills micahmills merged commit 949d0b8 into DiscipleTools:next Jun 21, 2024
2 checks passed
@Ashima-Arora Ashima-Arora deleted the Edit-page-components-integration-fixing branch June 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants