Second issue #2476
Closed
Second issue #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dt-assets/js/comments.js # dt-assets/js/settings.js # dt-assets/js/shared-functions.js # dt-core/admin/js/dt-options.js
corsacca
reviewed
May 22, 2024
|
|
||
| <tr class="language-row" data-lang="<?php echo esc_html( $language_key ) ?>"> | ||
| <td class='lang_key'><?php echo esc_html( $language_key ) ?></td> | ||
| <td class='default_label'><?php echo esc_html( isset( $dt_global_languages_list[$language_key] ) ? $dt_global_languages_list[$language_key]['label'] : '' ) ?></td> | ||
| <td class='custom_label'><input type="text" placeholder="Custom Label" name="language_label[<?php echo esc_html( $language_key ) ?>][default]" value="<?php echo esc_html( ( !isset( $dt_global_languages_list[$language_key] ) || ( isset( $dt_global_languages_list[$language_key] ) && $dt_global_languages_list[$language_key]['label'] != $language_option['label'] ) ) ? $language_option['label'] : '' ) ?>"></td> | ||
| <td class='iso_code'><input type="text" placeholder="ISO 639-3 code" maxlength="3" name="language_code[<?php echo esc_html( $language_key ) ?>]" value="<?php echo esc_html( $language_option['iso_639-3'] ?? '' ) ?>"></td> | ||
| <td class='custom_label'><input type="text" placeholder="Custom Label" name="language_label[<?php echo esc_html( $language_key ) ?>][default]" value="<?php echo esc_html( $language_option['label'] ?? '' )?>"></td> |
There was a problem hiding this comment.
@CptHappyHands keep the "custom" label blank if the admin has not saved a custom label yet. This should not be filled with the default label.
| <td class='custom_label'><input type="text" placeholder="Custom Label" name="language_label[<?php echo esc_html( $language_key ) ?>][default]" value="<?php echo esc_html( ( !isset( $dt_global_languages_list[$language_key] ) || ( isset( $dt_global_languages_list[$language_key] ) && $dt_global_languages_list[$language_key]['label'] != $language_option['label'] ) ) ? $language_option['label'] : '' ) ?>"></td> | ||
| <td class='iso_code'><input type="text" placeholder="ISO 639-3 code" maxlength="3" name="language_code[<?php echo esc_html( $language_key ) ?>]" value="<?php echo esc_html( $language_option['iso_639-3'] ?? '' ) ?>"></td> | ||
| <td class='custom_label'><input type="text" placeholder="Custom Label" name="language_label[<?php echo esc_html( $language_key ) ?>][default]" value="<?php echo esc_html( $language_option['label'] ?? '' )?>"></td> | ||
| <td class='iso_code'><input type="text" placeholder="ISO 639-3 code" maxlength="3" name="language_code[<?php echo esc_html( $language_key ) ?>]" value="<?php echo esc_html( $language_option['flag'] ?? '' ) ?>"></td> |
There was a problem hiding this comment.
Was iso_639-3 replaced with 'flag' here on accident?
| native_name: '', | ||
| flag: '', | ||
| rtl: false, | ||
| enabled: '', |
There was a problem hiding this comment.
Here we only want to save custom_label, iso_639-3 and enabled.
The rest should be removed
| }, | ||
| success: function (response) { | ||
| var languages = JSON.parse(response); | ||
| console.log(languages, 'success line 40'); |
There was a problem hiding this comment.
Nice work @CptHappyHands !
You can do window.location.reload() on the success for now.
Some in the other ajax
| /** | ||
| * @todo: | ||
| * only save user provided customizations to the dt_working_languages options | ||
| * this includes labels, the iso code, the enabled status and translations | ||
| * does not include: the key, default labels etc | ||
| */ | ||
|
|
||
| recursive_array_update( $saved_language_options, $params ); | ||
| update_option( 'dt_working_languages', $saved_language_options, false ); |
There was a problem hiding this comment.
@CptHappyHands
Here we only want to save the custom values the admin has entered. Not any that are default.
So if the admin sets english to enabled:
We'd do saved_language_options[en_US]['enabled'] = true
I expect a lot of the code from process_languages_box() would be copied here.
|
Closing this one in favor of: #2500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for troubleshooting