Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2319 - List Filters: Support Text & Comms-Channel Field Filters #2322

Conversation

kodinkat
Copy link
Contributor

@corsacca
Copy link
Member

@kodinkat Text field filtering api calls don't seem to be working for me working

@corsacca
Copy link
Member

Todo:
when the user fills out the input field, default to searching fields matching the text:
image

@corsacca
Copy link
Member

@kodinkat
The filter label in this case. Can it be adjusted to reflect the filtered text instead of "All".

image

@corsacca
Copy link
Member

@kodinkat
image
Is returning all contacts.

Should only return contacts with non empty values for the field.

Let's use for that search ['*'] instead of -*. (and update documentation).

@corsacca
Copy link
Member

@kodinkat
No sure how i missed this, but
image

Isn't showing any results?
image

@corsacca
Copy link
Member

@kodinkat
this one isn't working any more:
image

@corsacca
Copy link
Member

@kodinkat we want to try to move away from lodash.
Would you be willing to replace the 2 lodash functions ?

@corsacca
Copy link
Member

This is looking fantastic!

@@ -1081,6 +1081,42 @@
date.end = end
}
search_query.push({[field]: date})
} else if ( type === "text" || type === "communication_channel" ){
let value = '-*';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodinkat -* isn't a valid format, lets change the default

@corsacca
Copy link
Member

Thank you @kodinkat!

@corsacca corsacca merged commit ec03124 into DiscipleTools:develop Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants