Fix/dt login security fixes #2277
Conversation
require the css instead of registering it
…o control firebase
|
Did this first message show for you? |
|
Are we ok with obfuscation vs not being able to discover the value? (i think so, not a huge issue) |
ooh, I don't know if I saw/noticed that one |
Hmm, that's a good point, it doesn't change the |
dt-login/pages/base.php
Outdated
| body { | ||
| background: white; | ||
| } | ||
| <?php require __DIR__ . '/../../dt-assets/build/css/style.min.css' ?> |
There was a problem hiding this comment.
@squigglybob
this includes ALL of the 30 kB of D.T css in the header.
It is just for this UI, right:
There was a problem hiding this comment.
I could sift the CSS, for what is needed for this/ write some CSS to make it look like this 😆
There was a problem hiding this comment.
I've created a stripped down css for the login page, that has no dependencies on foundation either.
I wasn't able to test the page where you create a new password after receiving the lost password email. 😬
it was taking me to the wp-login new password page instead
|
Thank you @squigglybob ! |
resolves #2193