User IDs were being sent as an integer #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct ids when requesting a compact.
|
I found this when doing work in the 'next' branch with web components. I will add it there to make the web components work properly, but I thought I would add it as a separate PR on the main branch so we can test it and make sure it doesn't cause some unexpected problems. |
micahmills
added a commit
to micahmills/disciple-tools-theme
that referenced
this pull request
May 11, 2023
…ct ids when requesting a compact. Sent same change in PR DiscipleTools#2066 for further testing on main branch
corsacca
pushed a commit
that referenced
this pull request
May 15, 2023
* Fixes undefined index errors as well as fixes a variable name * Implemented multi-select * User IDs were being sent as an integer instead of a string like contact ids when requesting a compact. Sent same change in PR #2066 for further testing on main branch
|
@micahmills For consistency let's move towards IDs always being (int) |
micahmills
added a commit
to micahmills/disciple-tools-theme
that referenced
this pull request
Jun 11, 2023
This is the same as DiscipleTools#2066 but on the next branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User IDs were being sent as an integer instead of a string like contact ids when requesting a compact.