Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'field type' label to Edit Field modal #2035

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Added 'field type' label to Edit Field modal #2035

merged 2 commits into from
Apr 21, 2023

Conversation

prykon
Copy link
Collaborator

@prykon prykon commented Apr 12, 2023

Screenshot 2023-04-11 at 21 11 38

@prykon
Copy link
Collaborator Author

prykon commented Apr 12, 2023

Corresponds to this item: https://github.com/orgs/DiscipleTools/projects/13/views/1?pane=issue&itemId=24990379

@corsacca
Copy link
Member

@prykon lets use the labels instead of the keys:
image

@corsacca
Copy link
Member

Dropdown vs Key Select

@prykon
Copy link
Collaborator Author

prykon commented Apr 17, 2023

@corsacca We're using 'Dropdown' in the legacy wording. Would you like to change it to 'Key Select'? 'Dropdown' is more intuitive, IMO...

Screenshot 2023-04-17 at 08 59 49

@corsacca
Copy link
Member

Correct, we'd want it to say Dropdown.

I'm thinking we might want to build a Field Type array in the D.T core that could be reference from anywhere in the system.

@corsacca corsacca merged commit 6c7c0ee into DiscipleTools:master Apr 21, 2023
@corsacca
Copy link
Member

thanks @prykon

@prykon prykon deleted the new-settings-show-field-type branch April 21, 2023 14:51
corsacca added a commit that referenced this pull request May 5, 2023
@cairocoder01 @kodinkat
@corsacca @squigglybob @discipletoolsbot @weblate @micahmills @prykon
Merge 1.40.0 into next (#2060)
144e825 
* Ensure correct jwt error rest status code is returned (#2026)

* Site links; Fix calls when running on remotes, add get_site_key_by_dev_key function (#2028)

* Protection for listing post types on remote instances

* get_site_key_by_dev_key function

* Better default color select css (#2027)

* Fix merging when user has been deleted and when reason closed field is removed (#2025)

* SSO login redirect (#2014)

* feat: create/maintain redirect_to query param in login page

* feat: use correct redirect uri in the login form to go to the redirect

* fix: attempt to remove 404 from custom login page

* feat: instanstiate query params class when url class is newed up

* Add tags and mapping keys to core settings endpoint (#1994)

* Add more values to core settings endpoint

* Fix cache in dt_get_post_type_settings filter

* Translated using Weblate (Turkish (tr_TR)) (#2029)

Currently translated at 95.1% (1047 of 1100 strings)

Translated using Weblate (Persian (fa_IR))

Currently translated at 92.2% (1015 of 1100 strings)

Translated using Weblate (Spanish (Latin America))

Currently translated at 98.8% (1087 of 1100 strings)

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translated using Weblate (German (de_DE))

Currently translated at 93.8% (1031 of 1099 strings)

Translated using Weblate (German (de_DE))

Currently translated at 93.8% (1031 of 1099 strings)

Translated using Weblate (Romanian (ro_RO))

Currently translated at 93.7% (1030 of 1099 strings)

Translated using Weblate (Spanish (es_ES))

Currently translated at 98.9% (1088 of 1099 strings)

Translated using Weblate (Spanish (Latin America))

Currently translated at 98.9% (1088 of 1099 strings)

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.






Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/de_DE/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/es_419/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/es_ES/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/fa_IR/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/ro_RO/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/tr_TR/
Translation: Disciple.Tools/Disciple Tools Theme

Co-authored-by: Weblate <[email protected]>
Co-authored-by: Hanna Duhm <[email protected]>
Co-authored-by: Micah Mills <[email protected]>
Co-authored-by: Mike Allbutt <[email protected]>
Co-authored-by: Prykon <[email protected]>

* v1.39.1

* My user endpoint: add corresponds_to_contact

* Fix merging assigned to

* D.T Extensions: Make error message appear on false responses (#2038)

* D.T Extensions: Removed 'edit tile' feature for 'no tile/hidden' tile rundown element (#2037)

* API: Avoid create duplicate communication channels. Honor $silent flag. (#2042)

* D.T customizations: Added 'field type' label to Edit Field modal (#2035)

* Added 'field type' label to Edit Field modal

* Made field names be displayed as labels instead of keys

* * Create API: allow searching for duplicates via filter hook (#2043)

* Create API: allow searching for duplicates on name

* Check $silent in correct place

* D.T Customizations: Fixed draggable shadows UI bug (#2048)

* D.T Customizations: Fixed the autonavigation feature that takes you to the element from a help menu (#2047)

* v1.39.2

* D.T Customizations: New settings delete tile (#2034)

* Completed main functionality

* Added 'delete custom tile' functionality

* Fixed PHPCS

* Made all of a deleted tile's fields get moved to 'No Tile'

* Improved 'delete' link UI; Added animation for deleted tile fields into 'No Tile' menu

* Fixed bug in detection of custom/default tiles

* PHPCS done

* Upgrade p2p connection activity messages (#2052)

* Customizations (D.T): New settings tile preview update (#2040)

* Made Dropdown Field Types update on the preview tile upon creating them

* Removed empty field option element

* Made fields appear in order in tile rundown window

* Fixed bug that didn't display fields correctly if no custom order

* Preview tile updates on field reordering

* PHPCS done

* Update preview tile field option order

* fix field option sorting

* nextElementSibling might be "new field option"

* Fixed bug that didn't sort field options by clicking move icon

* Get correct field option row

* Fix for getting tile key

* Fix for getting tile key on field

---------

Co-authored-by: corsac <[email protected]>

* WP ADmin: replace menu icons with D.T icon (#2050)

* replace admin menu icons with D.T icon

* Update labels removing (D.T)

* Revert "Update labels removing (D.T)"

This reverts commit 2a0bd49.

* Fix values display in details tile

* Fix values display in details tile

* Lists: when loading more get 500 instead of 100 (#2053)

* People Group: Ability to install all, add country location_grid (#2039)

* #1834 - Keep user from double importing people groups

* #1962 - Ability to install all people groups

* #1963 - Add geolocation when installing people groups

* Addressed escaping code smells

* Addressed bitty code smells

* Added bulk people groups creation logic

* Added location grid ids by country level + Improved bulk import performance

* Addressed formatting and date/time code smells

* Removed people groups csv geolocations script functionality

* Ensure individual people group imports use country location_grid ids + Tidy up of group_search() logic

* Removed stale click event listeners on add all groups request

* Fix mapbox address geocoding (#2054)

* Lists: Add Split By For Current Filter (#2049)

* Initial logical flow framework

* add initial split by sql

* add initial split by sql

* Fleshed out split by filtering flow

* Capture location and general labels within returned split by summary

* Revised ui and labels + Support connection field types

* Corrected split-by summary counts + Reset split-by on global filter change

* Ensure complete clear-down of split-by area on current filter change + Revised connection field type filtering + Alter current filter on split-by request

* Removed forced altering of base current filter

* Remove empty object properties of type array

* Ensure removal logic is only applied at correct point in flow

* Revised connection field type logic + Descending ordering + Limit summary results

* Show loading spinner

* Let 'any' connection show both from and to

* Remove extra space

* More efficient getting post names and user display names. Fix assigned to filter.

---------

Co-authored-by: corsac <[email protected]>

* Lists: add a default list all permission (#2055)

* Lists: add a default list all permission

* Only register hook once

* fix

* v1.40.0

* implement dt-tags

---------

Co-authored-by: kodinkat <[email protected]>
Co-authored-by: corsacca <[email protected]>
Co-authored-by: squigglybob <[email protected]>
Co-authored-by: discipletoolsbot <[email protected]>
Co-authored-by: Weblate <[email protected]>
Co-authored-by: Hanna Duhm <[email protected]>
Co-authored-by: Micah Mills <[email protected]>
Co-authored-by: Mike Allbutt <[email protected]>
Co-authored-by: Prykon <[email protected]>
Co-authored-by: Dario Manoukian <[email protected]>
corsacca added a commit that referenced this pull request May 8, 2023
@cairocoder01 @kodinkat
@corsacca @squigglybob @discipletoolsbot @weblate @micahmills @prykon
Implement dt-connection (#2061)
77b3320 
* Ensure correct jwt error rest status code is returned (#2026)

* Site links; Fix calls when running on remotes, add get_site_key_by_dev_key function (#2028)

* Protection for listing post types on remote instances

* get_site_key_by_dev_key function

* Better default color select css (#2027)

* Fix merging when user has been deleted and when reason closed field is removed (#2025)

* SSO login redirect (#2014)

* feat: create/maintain redirect_to query param in login page

* feat: use correct redirect uri in the login form to go to the redirect

* fix: attempt to remove 404 from custom login page

* feat: instanstiate query params class when url class is newed up

* Add tags and mapping keys to core settings endpoint (#1994)

* Add more values to core settings endpoint

* Fix cache in dt_get_post_type_settings filter

* Translated using Weblate (Turkish (tr_TR)) (#2029)

Currently translated at 95.1% (1047 of 1100 strings)

Translated using Weblate (Persian (fa_IR))

Currently translated at 92.2% (1015 of 1100 strings)

Translated using Weblate (Spanish (Latin America))

Currently translated at 98.8% (1087 of 1100 strings)

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translated using Weblate (German (de_DE))

Currently translated at 93.8% (1031 of 1099 strings)

Translated using Weblate (German (de_DE))

Currently translated at 93.8% (1031 of 1099 strings)

Translated using Weblate (Romanian (ro_RO))

Currently translated at 93.7% (1030 of 1099 strings)

Translated using Weblate (Spanish (es_ES))

Currently translated at 98.9% (1088 of 1099 strings)

Translated using Weblate (Spanish (Latin America))

Currently translated at 98.9% (1088 of 1099 strings)

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.






Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/de_DE/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/es_419/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/es_ES/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/fa_IR/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/ro_RO/
Translate-URL: https://translate.disciple.tools/projects/disciple-tools/disciple-tools-theme/tr_TR/
Translation: Disciple.Tools/Disciple Tools Theme

Co-authored-by: Weblate <[email protected]>
Co-authored-by: Hanna Duhm <[email protected]>
Co-authored-by: Micah Mills <[email protected]>
Co-authored-by: Mike Allbutt <[email protected]>
Co-authored-by: Prykon <[email protected]>

* v1.39.1

* My user endpoint: add corresponds_to_contact

* Fix merging assigned to

* D.T Extensions: Make error message appear on false responses (#2038)

* D.T Extensions: Removed 'edit tile' feature for 'no tile/hidden' tile rundown element (#2037)

* API: Avoid create duplicate communication channels. Honor $silent flag. (#2042)

* D.T customizations: Added 'field type' label to Edit Field modal (#2035)

* Added 'field type' label to Edit Field modal

* Made field names be displayed as labels instead of keys

* * Create API: allow searching for duplicates via filter hook (#2043)

* Create API: allow searching for duplicates on name

* Check $silent in correct place

* D.T Customizations: Fixed draggable shadows UI bug (#2048)

* D.T Customizations: Fixed the autonavigation feature that takes you to the element from a help menu (#2047)

* v1.39.2

* D.T Customizations: New settings delete tile (#2034)

* Completed main functionality

* Added 'delete custom tile' functionality

* Fixed PHPCS

* Made all of a deleted tile's fields get moved to 'No Tile'

* Improved 'delete' link UI; Added animation for deleted tile fields into 'No Tile' menu

* Fixed bug in detection of custom/default tiles

* PHPCS done

* Upgrade p2p connection activity messages (#2052)

* Customizations (D.T): New settings tile preview update (#2040)

* Made Dropdown Field Types update on the preview tile upon creating them

* Removed empty field option element

* Made fields appear in order in tile rundown window

* Fixed bug that didn't display fields correctly if no custom order

* Preview tile updates on field reordering

* PHPCS done

* Update preview tile field option order

* fix field option sorting

* nextElementSibling might be "new field option"

* Fixed bug that didn't sort field options by clicking move icon

* Get correct field option row

* Fix for getting tile key

* Fix for getting tile key on field

---------

Co-authored-by: corsac <[email protected]>

* WP ADmin: replace menu icons with D.T icon (#2050)

* replace admin menu icons with D.T icon

* Update labels removing (D.T)

* Revert "Update labels removing (D.T)"

This reverts commit 2a0bd49.

* Fix values display in details tile

* Fix values display in details tile

* Lists: when loading more get 500 instead of 100 (#2053)

* People Group: Ability to install all, add country location_grid (#2039)

* #1834 - Keep user from double importing people groups

* #1962 - Ability to install all people groups

* #1963 - Add geolocation when installing people groups

* Addressed escaping code smells

* Addressed bitty code smells

* Added bulk people groups creation logic

* Added location grid ids by country level + Improved bulk import performance

* Addressed formatting and date/time code smells

* Removed people groups csv geolocations script functionality

* Ensure individual people group imports use country location_grid ids + Tidy up of group_search() logic

* Removed stale click event listeners on add all groups request

* Fix mapbox address geocoding (#2054)

* Lists: Add Split By For Current Filter (#2049)

* Initial logical flow framework

* add initial split by sql

* add initial split by sql

* Fleshed out split by filtering flow

* Capture location and general labels within returned split by summary

* Revised ui and labels + Support connection field types

* Corrected split-by summary counts + Reset split-by on global filter change

* Ensure complete clear-down of split-by area on current filter change + Revised connection field type filtering + Alter current filter on split-by request

* Removed forced altering of base current filter

* Remove empty object properties of type array

* Ensure removal logic is only applied at correct point in flow

* Revised connection field type logic + Descending ordering + Limit summary results

* Show loading spinner

* Let 'any' connection show both from and to

* Remove extra space

* More efficient getting post names and user display names. Fix assigned to filter.

---------

Co-authored-by: corsac <[email protected]>

* Lists: add a default list all permission (#2055)

* Lists: add a default list all permission

* Only register hook once

* fix

* v1.40.0

* implement dt-tags

* implement dt-connection

@d.t/w-c v0.3.2

* run gulp build to fix minified file

* allows for postTypes in the connection fields that are not the same as the current post.

This allows you to add a groups connection from a contact post or vice versa

* re-run gulp

* update components to 0.3.4

---------

Co-authored-by: kodinkat <[email protected]>
Co-authored-by: corsacca <[email protected]>
Co-authored-by: squigglybob <[email protected]>
Co-authored-by: discipletoolsbot <[email protected]>
Co-authored-by: Weblate <[email protected]>
Co-authored-by: Hanna Duhm <[email protected]>
Co-authored-by: Micah Mills <[email protected]>
Co-authored-by: Mike Allbutt <[email protected]>
Co-authored-by: Prykon <[email protected]>
Co-authored-by: Dario Manoukian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prykon @corsacca