feat: add new field type for date and time picker combined

[squigglybob]

resolves #1895

[corsacca]

@squigglybob is this still in draft mode?

[squigglybob]

yars, I think so. I can't remember why I didn't finish it, but it could probably use some double brains on it to work out the best way forward and what is necessary.

I was working on it, so that the PG laps, would be able to see/change the start time of a lap, but then it dropped lower in priority and I forgot to come back to it I think.

[squigglybob]

hey @corsacca finally got this one going 😀

[squigglybob]

hahaha, I thought I was done, but then we decided to split date field with optional time picker into
date field
and
datetime field

Let's split these babies up!!!

[squigglybob]

@zdmc23 There has been a new field type in the process of being added, so you're aware of it from the mobile side of things

[squigglybob]

Still todo

• add docs for the datetime field type
• display time with the date in the activity log
• add tests for the datetime field type
• test with private fields
• test with time travel roll back

[squigglybob]

Hey @corsacca,

This one is done and tested in the unit tests, and checked with record time travel.

I noticed that the curly brackets are being left around the timestamps in the record.

Is that intentional? Shall I create a new ticket to deal with that or do it in here?

[squigglybob]

I removed them 😆
It should'nt affect any situations where there aren't any brackets either, so should be ok

[corsacca]

thanks @squigglybob !

[squigglybob]

woop, that was a long time in the coming 😉