#1660 - Revert Record Back In Time Shape #1776

kodinkat · 2022-08-30T15:39:11Z

corsacca · 2022-09-08T13:54:46Z

Display name without the &
Order History in the same order as the comments section
Show all History in modal, calendar scrolls to the relevant section. Confused as to how much history is shown when.
Should comment be deleted? (revert history and comments?)
Revert activity done by "Revert Bot" instead of by the user.
Milestone (multi select) don't want to revert.
delete history since selected revision ?
get activity message formatted.

# Conflicts: # dt-assets/build/css/style.min.css # dt-contacts/base-setup.php # dt-people-groups/people-groups-base.php # dt-posts/dt-posts.php # single-template.php

corsacca · 2022-11-30T10:13:05Z

dt-assets/functions/enqueue-scripts.php

@@ -348,6 +348,24 @@ function dt_site_scripts() {
 'template_dir_uri' => esc_html( get_template_directory_uri() ),
 'fetch_more_text' => __( 'Load More', 'disciple_tools' ) // Support translations
 ) );
+
+ wp_register_script( 'litepicker', 'https://cdn.jsdelivr.net/npm/litepicker/dist/litepicker.js', false );


@kodinkat lets us the existing date range picker.

See metrics, and tasks

corsacca · 2022-11-30T10:19:15Z

dt-assets/js/record-history.js

+ field_label = 'contact_other';
+
+ } else {
+ field_label = 'communication_channel';


This section can modularized.

corsacca · 2022-11-30T10:21:34Z

dt-posts/dt-posts.php

+ $field_key = 'contact_twitter';
+
+ } elseif ( substr( $field_key, 0, strlen( 'contact_other_' ) ) == 'contact_other_' ) {
+ $field_key = 'contact_other';


This section can be modularized to accommodate for custom channels.

dt-posts/dt-posts.php

corsacca · 2022-11-30T10:34:41Z

Address: Name in modal

kodinkat · 2022-11-30T10:48:41Z

Address: Name in modal

Including:

Correct timestamp formats.
Activated Links.

…g + Dynamic location_meta keep lookups + Support number min/max bounds

…h select widget + Additional permissions + Formatted links + Revert to specific activity record + Resolved groups connection field revert issue

…ols-theme into 1660-revert-record-back-in-time

corsacca · 2023-03-03T09:46:12Z

Duplicate dates, comes from opening the modal multiple times.

corsacca · 2023-03-03T09:53:19Z

Filter not always working?
No error logs

corsacca · 2023-03-03T09:53:48Z

A bunch of fields did not revert:

corsacca · 2023-03-03T09:33:14Z

dt-assets/parts/modals/modal-record-history.php

+ </tr>
+ <tr style="border: none;">
+ <td style="vertical-align: top;">
+ <span><?php echo esc_html( _x( 'Show All', 'Show All', 'disciple_tools' ) ) ?></span>


No need to add context if the string is the same as the context.
Adding the context can result in an extra string to translate

corsacca · 2023-03-03T09:34:31Z

dt-contacts/base-setup.php

@@ -386,7 +386,7 @@ public function dt_custom_fields_settings_after_combine( $fields, $post_type ){
 public static function dt_record_admin_actions( $post_type, $post_id ){
 if ( $post_type === 'contacts' ){
 $post = DT_Posts::get_post( $post_type, $post_id );
- if ( empty( $post['archive'] ) && isset( $post['type'] ) && ( $post['type']['key'] === 'personal' || $post['type']['key'] === 'placeholder' ) ) :?>
+ if ( empty( $post['archive'] ) && isset( $post['type'] ) && isset( $post['type'] ) && ( $post['type']['key'] === 'personal' || $post['type']['key'] === 'placeholder' ) ) :?>


@kodinkat this is duplicate?

corsacca · 2023-03-03T09:36:07Z

dt-posts/dt-posts-endpoints.php

+ register_rest_route(
+ $this->namespace, '/(?P<post_type>\w+)/(?P<id>\d+)/revert_activity_history', [
+ [
+ 'methods' => 'GET',


Would be a post request more naturally

kodinkat · 2023-03-06T12:22:03Z

Filter not always working?
No error logs

@corsacca

Typically, this filters from most recent date to selected filtered date. So, you should be able to scroll down in time to selected date?

kodinkat · 2023-03-06T12:26:44Z

A bunch of fields did not revert:

@corsacca

Suitable user capabilities added and the following A Beautiful Tile fields sanity-checked:

Number field [number]
Text [text]
Communication Channel [communication_channel]
User Select [user_select]
location field [location]
Date Field [date]
Random Options [multi_select]
Random Options [key_select]
Random Tags [tags]
Link Field [link]

Let me know if you are still encountering any troublesome fields/values?

kodinkat · 2023-03-06T12:28:09Z

Duplicate dates, comes from opening the modal multiple times.

@corsacca

Good spot! 😄 A fix has now been worked in...!

corsacca · 2023-03-07T07:39:41Z

Filter not always working?
No error logs

@corsacca

Typically, this filters from most recent date to selected filtered date. So, you should be able to scroll down in time to selected date?

@kodinkat Let's filter this to just show the day selected. There might be 100s of activity between today and the date selected.

dt-posts/dt-posts.php

corsacca · 2023-03-09T16:04:35Z

No history or revert ability on Name

Number field did not revert?

corsacca · 2023-03-10T11:16:16Z

Number not changing is prob related to: #1969

kodinkat · 2023-03-10T12:33:13Z

Number not changing is prob related to: #1969

@corsacca

Yup, that's most likely the cause; as no update action whenever there is a min/max constraint on the field.

I'll look into the reverting of record Names, issue...

…ols-theme into 1660-revert-record-back-in-time

…y record inserts

corsacca · 2023-03-14T10:39:45Z

dt-posts/dt-posts.php

+ AND `action` IN ( $supported_actions_sql )
+ AND `field_type` IN ( $supported_field_types_sql )
+ AND `hist_time` BETWEEN %d AND %d
+ ORDER BY hist_time $result_order",


@kodinkat $result_order is NOT escaped

…activity listing endpoints

corsacca · 2023-03-16T07:53:59Z

@kodinkat !!!!!

kodinkat changed the title ~~#1660 - Revert Record Back In Time Shape~~ WIP: #1660 - Revert Record Back In Time Shape [DO_NOT_MERGE] Aug 30, 2022

kodinkat changed the title ~~WIP: #1660 - Revert Record Back In Time Shape [DO_NOT_MERGE]~~ #1660 - Revert Record Back In Time Shape Sep 6, 2022

kodinkat force-pushed the 1660-revert-record-back-in-time branch from 471e7bf to 14ef2b3 Compare September 6, 2022 10:42

kodinkat force-pushed the 1660-revert-record-back-in-time branch from 1d70edc to 02bcedd Compare September 14, 2022 10:37

kodinkat added 5 commits September 14, 2022 11:39

Initial revert record back in time shape

de28e62

Reformatted dt-posts.php file

5a94eca

Support both connection and communication_channel field types

c26919e

Refreshed style.min.css

dbdcb6c

Ensure all field types revert + Visual updates

7684c5c

kodinkat force-pushed the 1660-revert-record-back-in-time branch from 02bcedd to 7684c5c Compare September 14, 2022 10:40

kodinkat and others added 8 commits September 14, 2022 12:16

Addressed assignment code smell

4a1b745

Introduced style css new line

176bca3

Refreshed _main.scss

a9f8d2c

update package-log

1b9179a

rebuild css

7e77a1c

Merge branch 'master' into 1660-revert-record-back-in-time

ed9e0e5

# Conflicts: # dt-assets/build/css/style.min.css # dt-contacts/base-setup.php # dt-people-groups/people-groups-base.php # dt-posts/dt-posts.php # single-template.php

phpcbf and and rebuild styles

52d1aa6

revert package lock

12ff208

corsacca reviewed Nov 30, 2022

View reviewed changes

WIP: Initial shape of refactored core revert logic

8f07e12

kodinkat marked this pull request as draft December 7, 2022 09:01

kodinkat added 2 commits December 8, 2022 13:54

Latest revert logic shape - Still testing....

efbde1f

Resolved communication_channel duplicates + Cleaner exception handlin…

64c6fb8

…g + Dynamic location_meta keep lookups + Support number min/max bounds

kodinkat marked this pull request as ready for review December 9, 2022 17:03

kodinkat added 3 commits December 12, 2022 12:32

Better support of user_select blank user- entries

0cc96e4

Force show all activities by default + Replaced date range picker wit…

59d04d9

…h select widget + Additional permissions + Formatted links + Revert to specific activity record + Resolved groups connection field revert issue

Merge branch 'master' of https://github.com/DiscipleTools/disciple-to…

e01fdde

…ols-theme into 1660-revert-record-back-in-time

kodinkat and others added 6 commits February 28, 2023 17:12

Merge branch 'master' of https://github.com/DiscipleTools/disciple-to…

4f83ee0

…ols-theme into 1660-revert-record-back-in-time

Merge branch 'master' of https://github.com/DiscipleTools/disciple-to…

e171c09

…ols-theme into 1660-revert-record-back-in-time

Added support for link field types

059eb87

Merge branch 'master' of https://github.com/DiscipleTools/disciple-to…

4f71527

…ols-theme into 1660-revert-record-back-in-time

Addressed static member reference code smell

bf323c5

Only load js on details pages

156f8fe

Change string translation

b0cc197

corsacca reviewed Mar 3, 2023

View reviewed changes

Addressed snag-list + Additional field sanity checks

6dcc857

corsacca reviewed Mar 7, 2023

View reviewed changes

dt-posts/dt-posts.php Show resolved Hide resolved

Filter to only show selected day + Suitable revert bot variable name.

6b22d3e

corsacca reviewed Mar 7, 2023

View reviewed changes

dt-posts/dt-posts.php Outdated Show resolved Hide resolved

Ignore permission checks for revert bot during field updates

b967c41

kodinkat added 2 commits March 10, 2023 13:14

Merge branch 'master' of https://github.com/DiscipleTools/disciple-to…

9b15a9d

…ols-theme into 1660-revert-record-back-in-time

Ensure title/name updates also capture text field type within activit…

3b4c295

…y record inserts

corsacca reviewed Mar 14, 2023

View reviewed changes

corsacca and others added 2 commits March 14, 2023 11:40

Don't trigger notifications on revert

829fb5d

Reduced activity endpoint calls on history modal show + Consolidated …

f1001e6

…activity listing endpoints

corsacca merged commit ba9408d into DiscipleTools:master Mar 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1660 - Revert Record Back In Time Shape #1776

#1660 - Revert Record Back In Time Shape #1776

kodinkat commented Aug 30, 2022

corsacca commented Sep 8, 2022 •

edited

Loading

corsacca Nov 30, 2022

corsacca Nov 30, 2022

corsacca Nov 30, 2022

corsacca Nov 30, 2022

corsacca commented Nov 30, 2022

kodinkat commented Nov 30, 2022

corsacca commented Mar 3, 2023 •

edited

Loading

corsacca commented Mar 3, 2023

corsacca commented Mar 3, 2023

corsacca Mar 3, 2023

corsacca Mar 3, 2023

corsacca Mar 3, 2023

kodinkat commented Mar 6, 2023

kodinkat commented Mar 6, 2023

kodinkat commented Mar 6, 2023

corsacca commented Mar 7, 2023

corsacca commented Mar 9, 2023 •

edited

Loading

corsacca commented Mar 10, 2023

kodinkat commented Mar 10, 2023

corsacca Mar 14, 2023

corsacca commented Mar 16, 2023

#1660 - Revert Record Back In Time Shape #1776

#1660 - Revert Record Back In Time Shape #1776

Conversation

kodinkat commented Aug 30, 2022

corsacca commented Sep 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corsacca commented Nov 30, 2022

kodinkat commented Nov 30, 2022

corsacca commented Mar 3, 2023 • edited Loading

corsacca commented Mar 3, 2023

corsacca commented Mar 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kodinkat commented Mar 6, 2023

kodinkat commented Mar 6, 2023

kodinkat commented Mar 6, 2023

corsacca commented Mar 7, 2023

corsacca commented Mar 9, 2023 • edited Loading

corsacca commented Mar 10, 2023

kodinkat commented Mar 10, 2023

Choose a reason for hiding this comment

corsacca commented Mar 16, 2023

corsacca commented Sep 8, 2022 •

edited

Loading

corsacca commented Mar 3, 2023 •

edited

Loading

corsacca commented Mar 9, 2023 •

edited

Loading