New role and capabilities manager #1584
Conversation
…ols-theme # Conflicts: # dt-contacts/base-setup.php # dt-core/global-functions.php
…ols-theme # Conflicts: # dt-core/admin/js/dt-utilities-scripts.js
|
@corsacca See Travis log. Any tips on getting the composer install to work for PHP 8? |
| /** | ||
| * Dump and die | ||
| */ | ||
| if ( !function_exists( 'dd' ) ) { |
There was a problem hiding this comment.
It stands for dump and die. It dumps a given variable (or variables) and ends execution of the script. It's a convenience utility function you'll find in some PHP frameworks. I'm happy to remove it, but it's so much easier to write:
dd($foo, $bar);
instead of:
var_dump($foo); var_dump($bar); exit;
|
@corsacca, I've made a round of revisions. Let me know if you would like any further changes. |
|
@corsacca, any idea why there are tests failing? Those don't seem to be related to my work. |
|
@corsacca, I reverted the phpunit changes. I'll hold on making a pull request for that. I was pretty sure that wasn't the right solution. I was just getting it working for me locally, but I'm sure it's not the right solution (see our slack conversation regarding from around the time of the commit). |
|
@incraigulous small issue with tab not opening: |
|
@incraigulous |
|
These are wp caps: |
@corsacca I was able to solve this by loading the roles on the front-end as well as the back-end. You mentioned in a previous comment that you wanted me to set up the custom roles in |
@corsacca Odd... those roles aren't showing up for me anymore, though they used to. I assumed you removed them. Can you confirm your WP is updated to the latest version and that they are still showing up for you?
|
|
@incraigulous you are right about the roles setup needing to be available on each request. For the level 0 to level 10. I checked out the branch on 3 instances, one of them a clean install and see the them show up. |
|
@corsacca, I just pushed a commit to allow us to remove specific capabilities, namely, level_0 - level_9. |
|
Thank @incraigulous. Would you be able to fix the phpcs check? |
|
Fixed!
Thank you!
*CRAIG WANN*
Mobile: (918) 641-4282
…On Wed, Apr 27, 2022 at 3:03 AM corsacca ***@***.***> wrote:
Thank @incraigulous <https://github.com/incraigulous>. Would you be able
to fix the phpcs check?
—
Reply to this email directly, view it on GitHub
<#1584 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNC6GNVJIPUOGH7D345J6LVHDYDZANCNFSM5NYB7O6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you @incraigulous ! |
|
🥳 , thank you, @corsacca! |
https://www.loom.com/share/e46ed2d5c25041c1897ec3ee9944e531