Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expandability to activity log metrics #1490

Conversation

squigglybob
Copy link
Collaborator

resolves #1486

@squigglybob
Copy link
Collaborator Author

@corsacca how about like this?

I've used the same chevrons from collapsible border boxes if that's ok?

@corsacca
Copy link
Member

Chevrons are good.
Looks great on the users_management page.
On the metrics page i'm worrier it will be overlooked because it is far off to the right:
image
Thoughts on how to bring the chevron in closer?

@squigglybob
Copy link
Collaborator Author

@corsacca We could make the paper half the width of the screen on larger screens. The width seems too large for the content.

@squigglybob squigglybob changed the title refactor: make html creation a little clearer feat: add expandability to activity log metrics Oct 12, 2021
@squigglybob
Copy link
Collaborator Author

also, and this may be connected to creation of translateable object_notes, but the date here is going to need momentifying
image

@squigglybob
Copy link
Collaborator Author

squigglybob commented Oct 12, 2021

also also, duplicates has an ugly message in activity logs, that should maybe be filtered out... 😶‍🌫️
image

@corsacca
Copy link
Member

That looks better!
window.SHAREDFUNCTIONS.formatDate() for the date fields
we don't want to display the array field type, or any non usual field type

@squigglybob
Copy link
Collaborator Author

What other non-usual field types are there?

@squigglybob
Copy link
Collaborator Author

@corsacca I think that addresses everything we mentioned...

@squigglybob
Copy link
Collaborator Author

@corsacca OK, now comments should be formatted. I noticed while doing this, that the @comment links are broken...

@corsacca corsacca merged commit bc8b2ee into DiscipleTools:master Oct 13, 2021
@squigglybob squigglybob deleted the 1486-expandable-activities-metric-details branch October 14, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanded details for activity metrics
2 participants